Found a bug.
I have a song with 11 tracks and 5 of them are percussion. Before the preview I had all the tracks instrument set to 0(The first piano). except for the percussion wich where set to Not played hidden.
Now with the preview the First percussion track is still being played. (track #4) Even when I set Everything to Not played, that track is still played.
Oh and there was some other song that all the Played By got messed up. But I fixed it and don't remember the song.
Sorry It took me so long to post this. (Iv known this bug existed sence the preview was released. ) Iv been lazy.
lol got top of page twice for today.
0.8.2 Preview r1310 - Device rework and bug fixes
Archived development updates.
The problem stems from the track count and track order being shimmied around because of fixes made to song loading. You can fix it by clicking "Reset All" and just going through and changing your instruments one more time.Raymond wrote:Found a bug.
There is a different problem though: the track count shouldn't have changed in that song. Check out the log after you load it:
Code: Select all
[WARN ] 2011-Jul-19 03:21:21 src\libmidi\MidiTrack.cpp:246: Dropped 254 never ending note(s).
[WARN ] 2011-Jul-19 03:21:21 src\libmidi\MidiTrack.cpp:246: Dropped 106 never ending note(s).
[WARN ] 2011-Jul-19 03:21:21 src\libmidi\MidiTrack.cpp:246: Dropped 185 never ending note(s).
[WARN ] 2011-Jul-19 03:21:21 src\libmidi\MidiTrack.cpp:246: Dropped 270 never ending note(s).
[WARN ] 2011-Jul-19 03:21:21 src\libmidi\MidiTrack.cpp:246: Dropped 1 never ending note(s).
[WARN ] 2011-Jul-19 03:21:21 src\libmidi\MidiTrack.cpp:246: Dropped 1 never ending note(s).
I fixed it by allowing more than one of the same note on the same channel to be "open" at the same time. Before the behavior was that a new note-on would implicitly "close" the previous note-on if we hadn't seen one before. In the On, On, Off, Off case (where the 2nd and 3rd events were at the same time point, only unfortunately swapped by a bad MIDI editor), you don't get what look to be super-short notes anymore.readme.txt wrote:Rare (ambiguous) event ordering in MIDI files could cause the second of two consecutive notes to appear very short, despite the spark effect still showing correctly.
The problem (apparently) is that whichever editor created that MIDI file of yours, seems to think percussion can just be note-ons forever without a note-off ever.
I could claim "Bad MIDI! Not my problem!" but I won't. Maybe that's a thing that happens to percussion a lot. So, I'll amend my fix so it will still let note-ons close previous notes if the event happens to be a percussion channel.
After the fix, it looks like this:
Code: Select all
[WARN ] 2011-Jul-19 03:38:58 src\libmidi\miditrack.cpp:252: Dropped 1 never ending note(s).
[WARN ] 2011-Jul-19 03:38:58 src\libmidi\miditrack.cpp:252: Dropped 1 never ending note(s).
[WARN ] 2011-Jul-19 03:38:58 src\libmidi\miditrack.cpp:252: Dropped 1 never ending note(s).
[WARN ] 2011-Jul-19 03:38:58 src\libmidi\miditrack.cpp:252: Dropped 1 never ending note(s).
[WARN ] 2011-Jul-19 03:38:58 src\libmidi\miditrack.cpp:252: Dropped 1 never ending note(s).
[WARN ] 2011-Jul-19 03:38:58 src\libmidi\miditrack.cpp:252: Dropped 1 never ending note(s).
I remember trying that when r1310 came out. I'll try it in r1352.Nicholas wrote:You can fix it by clicking "Reset All" and just going through and changing your instruments one more time.
Ya I do remember seeing that. My SB Live Synth doesn't like it.Nicholas wrote:seems to think percussion can just be note-ons forever without a note-off ever.
Ya I do have a few other songs that are like that..Nicholas wrote:Maybe that's a thing that happens to percussion a lot.
That does look like that will fix the problem with Synthesia. But I am not sure about my synth.Nicholas wrote:the fix
The problem is that my synth can only hold 32 notes at one time. every percussion note under middle C, will automatically release itself. but not middle C and above.
So after a bit the queue gets full. and then all I hear is percussion... Now I don't have any problems while playing because I always disable most if not all percussion.
So it's not really a bug you should worry about. But well see, maybe turning them off every time it gets a new on event, will be enough to fix that aswell.